[INLONG-4659][Sort] Support field routing for Elasticsearch connector #4849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1.Multiple module titles must correspond. |
healchow
reviewed
Jul 3, 2022
|
@Oneal65 there are UTs failed, please check again. |
healchow
changed the title
|
1.The problem background needs to be added. |
@GanfengTan Now, you can see it In Background, Design ideas and others |
@dockerzhang DONE |
GanfengTan
requested changes
Jul 6, 2022
...arch-base/src/main/java/org/apache/inlong/sort/elasticsearch/table/ElasticsearchOptions.java
Show resolved
Hide resolved
...rch-base/src/main/java/org/apache/inlong/sort/elasticsearch/table/IndexGeneratorFactory.java
Show resolved
Hide resolved
...rch-base/src/main/java/org/apache/inlong/sort/elasticsearch/table/IndexGeneratorFactory.java
Show resolved
Hide resolved
...lasticsearch-base/src/main/java/org/apache/inlong/sort/elasticsearch/table/KeyExtractor.java
Show resolved
Hide resolved
gong
reviewed
Jul 7, 2022
...rt-common/src/main/java/org/apache/inlong/sort/protocol/node/load/ElasticsearchLoadNode.java
Outdated
Show resolved
Hide resolved
gong
approved these changes
Jul 7, 2022
GanfengTan
approved these changes
Jul 7, 2022
thesumery
approved these changes
Jul 7, 2022
EMsnap
approved these changes
Jul 7, 2022
|
please unify all the dependency versions for the |
@dockerzhang done |
healchow
approved these changes
Jul 7, 2022
dockerzhang
approved these changes
Jul 7, 2022
bruceneenhl
pushed a commit
to bruceneenhl/inlong
that referenced
this pull request
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
Motivation
Support field routing for ElasticSearch connector
Modifications
according to https://github.com/apache/flink/pull/14493/files
and https://github.com/apache/flink/tree/release-1.13.2-rc2
modify the whole sort-connector-elasticsearch6 and sort-connector-elasticsearch7 code
and add sort-connector-elasticsearch-base module
Background, Design ideas and others
Background: the field routing concept, there are some URLs:
https://www.cnblogs.com/bonelee/p/6055340.html
https://www.cnblogs.com/Rawls/p/10269192.html
Design ideas:
the routing function has been supported By ElasticSearch. What we should do is add this feature to the connector.
the main logic is in RoutingExtractor class
this PR is refer to:
https://github.com/apache/flink/pull/14493/files
https://github.com/apache/flink/tree/release-1.13.2-rc2
Verifying this change
This change added tests and can be verified as follows:
Elasticsearch6DynamicSinkITCase.java
Elasticsearch7DynamicSinkITCase.java
TestContext.java
Documentation