Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-4769][CI] Fix error trigger condition in the docker workflow #4770

Merged
merged 1 commit into from
Jun 25, 2022

Conversation

shink
Copy link
Member

@shink shink commented Jun 24, 2022

Fixes #4769

Motivation

Now, if only the source codes are changed, the docker workflow won't be triggerd.
If the source codes are changed, the docker workflow should be triggered when pushing them, and not in a pull request.

Modifications

In a pull request. the docker workflow is only triggered when the build files are changed.
In a pushed commit, changes to the source codes or build files will both trigger the docker workflow.
So, if you just changed the source codes, the docker workflow will not be triggered in you pull request, but it will be triggered when your pull request is merged.

on:
  push:
    paths:
      - '.github/workflows/ci_docker.yml'
      - '**/pom.xml'
      - 'inlong-agent/**'
      - 'inlong-audit/**'
      - 'inlong-common/**'
      - 'inlong-dashboard/**'
      - 'inlong-dataproxy/**'
      - 'inlong-distribution/**'
      - 'inlong-manager/**'
      - 'inlong-sdk/**'
      - 'inlong-sort/**'
      - 'inlong-sort-standalone/**'
      - 'inlong-tubemq/**'
      - '!**.md'

  pull_request:
    paths:
      - '.github/workflows/ci_docker.yml'
      - '**/Dockerfile'
      - 'inlong-agent/agent-docker/**'
      - 'inlong-audit/audit-docker/**'
      - 'inlong-dataproxy/dataproxy-docker/**'
      - 'inlong-manager/manager-docker/**'
      - 'inlong-tubemq/tubemq-docker/**'
      - '!**.md'

@shink shink requested review from dockerzhang and healchow June 24, 2022 12:40
@shink shink self-assigned this Jun 24, 2022
@github-actions github-actions bot added the service/ci Automatically confirm that the code is error-free label Jun 24, 2022
@shink shink changed the title [INLONG-4769] Fix error trigger condition in the docker workflow [INLONG-4769][CI] Fix error trigger condition in the docker workflow Jun 24, 2022
@dockerzhang dockerzhang merged commit 8ea2cee into apache:master Jun 25, 2022
vernedeng pushed a commit to vernedeng/incubator-inlong that referenced this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/ci Automatically confirm that the code is error-free
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][CI] Error trigger conditions in the docker workflow
4 participants