Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-4741][Audit] AuditStore support ClickHouse sink #4747

Merged
merged 5 commits into from
Jun 30, 2022

Conversation

luchunliang
Copy link
Contributor

Prepare a Pull Request

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve?

Modifications

Describe the modifications you've done.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@dockerzhang
Copy link
Contributor

@luchunliang thanks for completing this feature, there are two more things you need to do with PR.
1, please add a configuration guide in the audit doc.
2, add a license for the new ru.yandex.clickhouse dependency.

@dockerzhang
Copy link
Contributor

please remove LICENSE-clickhouse-jdbc.txt file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Audit] AuditStore support ClickHouse sink
6 participants