Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-3117][Sort-Standalone] Fix parameter error when invoking SortSdk ack method #3125

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

vernedeng
Copy link
Contributor

Title Name: [INLONG-3117][Bug] Fix bug of parameter error when invoking SortSdk ack method

Fixes #3117

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@vernedeng vernedeng changed the title [INLONG-3117][Bug] Fix bug of parameter error when invoking SortSdk ack method [INLONG-3117][Bug][Sort] Fix bug of parameter error when invoking SortSdk ack method Mar 14, 2022
@healchow healchow added this to the 1.1.0 milestone Mar 14, 2022
@healchow healchow changed the title [INLONG-3117][Bug][Sort] Fix bug of parameter error when invoking SortSdk ack method [INLONG-3117][Sort-Standalone] Fix parameter error when invoking SortSdk ack method Mar 14, 2022
@dockerzhang dockerzhang merged commit a2d2319 into apache:master Mar 14, 2022
@vernedeng vernedeng deleted the INLONG-3117 branch May 26, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Sort-Standalone] Parameter error when invoking SortSdk ack method
3 participants