[INLONG-2877][Agent] Task position manager throws NPE when send dataproxy ack success #2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dataproxy ack success
aloyszhang
reviewed
Mar 3, 2022
...ng-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sinks/SenderManager.java
Show resolved
Hide resolved
healchow
reviewed
Mar 3, 2022
| @@ -206,7 +206,13 @@ public void onMessageAck(SendResult result) { | |||
| return; | |||
| } | |||
| metric.incSendSuccessNum(bodyList.size()); | |||
| taskPositionManager.updateSinkPosition(jobId, sourcePath, bodyList.size()); | |||
| /** | |||
There was a problem hiding this comment.
It's not necessary to use Javadoc in any method.
There was a problem hiding this comment.
It's confusing if I don't add this comment
healchow
changed the title
healchow
changed the title
aloyszhang
approved these changes
Mar 4, 2022
dockerzhang
approved these changes
Mar 4, 2022
EMsnap
commented
Mar 4, 2022
| @@ -206,7 +206,13 @@ public void onMessageAck(SendResult result) { | |||
| return; | |||
| } | |||
| metric.incSendSuccessNum(bodyList.size()); | |||
| taskPositionManager.updateSinkPosition(jobId, sourcePath, bodyList.size()); | |||
| /** | |||
There was a problem hiding this comment.
It's confusing if I don't add this comment
|
Solved in #2881 (review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[INLONG-2877][Agent] Task position manager throws NPE when sending dataproxy ack success
Fixes #2877
Motivation
Agent task position manager throws NPE when sending dataproxy ack success
Modifications
Agent task position manager throws NPE when sending dataproxy ack success when there is no source, the position should not be stored locally since we report snapshot to the manager-module already.
Verifying this change
Documentation