Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-2210] package inlong-manager-web as inlong-manager #2212

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

dockerzhang
Copy link
Contributor

@dockerzhang dockerzhang commented Jan 20, 2022

Title Name: [INLONG-XYZ][component] Title of the pull request

where XYZ should be replaced by the actual issue number.

Fixes #2210

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@dockerzhang dockerzhang added this to the 0.13.0 milestone Jan 20, 2022
@dockerzhang dockerzhang changed the title [INLONG-2110] package inlong-manager-web as inlong-manager [INLONG-2210] package inlong-manager-web as inlong-manager Jan 20, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2212 (148d277) into master (75a21cd) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2212      +/-   ##
============================================
- Coverage     12.58%   12.58%   -0.01%     
+ Complexity     1208     1206       -2     
============================================
  Files           417      417              
  Lines         35735    35735              
  Branches       5590     5590              
============================================
- Hits           4499     4497       -2     
  Misses        30435    30435              
- Partials        801      803       +2     
Impacted Files Coverage Δ
.../producer/qltystats/DefaultBrokerRcvQltyStats.java 45.31% <0.00%> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75a21cd...148d277. Read the comment docs.

Copy link
Contributor

@gosonzhang gosonzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@dockerzhang dockerzhang merged commit 5a8a71f into apache:master Jan 20, 2022
@dockerzhang dockerzhang deleted the fix-2210 branch February 11, 2022 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve] package inlong-manager-web as inlong-manager
4 participants