Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-2064] tubemq-manager TopicEntry.java:[28,36] package javax.validation.constraints not exists #2065

Merged
merged 1 commit into from
Dec 28, 2021

Conversation

liaorui
Copy link
Contributor

@liaorui liaorui commented Dec 28, 2021

Title Name: [INLONG-2064][tubemq-manager] solved: tubemq-manager TopicEntry.java:[28,36] package javax.validation.constraints not exists

Fixes #2064

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov-commenter
Copy link

Codecov Report

Merging #2065 (f489e61) into master (1517148) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2065   +/-   ##
=========================================
  Coverage     12.28%   12.28%           
  Complexity     1157     1157           
=========================================
  Files           413      413           
  Lines         35215    35215           
  Branches       5542     5542           
=========================================
  Hits           4325     4325           
  Misses        30119    30119           
  Partials        771      771           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1517148...f489e61. Read the comment docs.

@dockerzhang dockerzhang changed the title solved: tubemq-manager TopicEntry.java:[28,36] package javax.validatio… [INLONG-2064] tubemq-manager TopicEntry.java:[28,36] package javax.validation.constraints not exists Dec 28, 2021
@dockerzhang
Copy link
Contributor

@gosonzhang PTAL

Copy link
Contributor

@EMsnap EMsnap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@gosonzhang gosonzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gosonzhang gosonzhang merged commit 12b4004 into apache:master Dec 28, 2021
@gosonzhang gosonzhang added the type/bug Something is wrong label Dec 28, 2021
@gosonzhang
Copy link
Contributor

@liaorui, thanks for your contribution!

EMsnap pushed a commit to EMsnap/incubator-tubemq that referenced this pull request Dec 28, 2021
…lidation.constraints not exists (apache#2065)

Co-authored-by: ryanrliao <ryanrliao@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]master branch, tubemq-manager module occurs: package Java.validation.constraints not exists
5 participants