[INLONG-1889] add Inlong-sort-standalone module structure #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dockerzhang
changed the title
dockerzhang
changed the title
dockerzhang
reviewed
Dec 7, 2021
inlong-sort-standalone/sort-standalone-dist/src/main/assembly/assembly.xml
Outdated
Show resolved
Hide resolved
...lone/sort-standalone-source/src/main/java/org/apache/inlong/sort/standalone/Application.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1913 +/- ##
============================================
+ Coverage 12.26% 12.28% +0.01%
- Complexity 1155 1158 +3
============================================
Files 413 413
Lines 35225 35225
Branches 5542 5542
============================================
+ Hits 4322 4326 +4
+ Misses 30133 30132 -1
+ Partials 770 767 -3
Continue to review full report at Codecov.
|
dockerzhang
approved these changes
Dec 7, 2021
healchow
reviewed
Dec 7, 2021
| language governing permissions and limitations under the License. --> | ||
|
|
||
| <project xmlns="http://maven.apache.org/POM/4.0.0" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" |
There was a problem hiding this comment.
Please use 4 spaces instead of Tab.
There was a problem hiding this comment.
ok, use 4 spaces instead of Tab.
| * @param args | ||
| */ | ||
| public static void main(String[] args) { | ||
| // LOG.info("start to sort-standalone"); |
There was a problem hiding this comment.
Please remove those unused codes.
There was a problem hiding this comment.
ok, remove those unused codes.
use 4 spaces instead of Tab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title Name: [INLONG-1889]Inlong-Sort-Standalone add Inlong-sort-standalone module structure.
for such sub-module:
Fixes #1889
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation