Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(catalog/glue): add checkNamespaceExist #312

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

dttung2905
Copy link
Contributor

Hi team,
Its a smaller PR this time round. I did a check in the https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/glue but couldnt find any method to directly check namespace's existance. Hence, I borrow similar logic from DropNamespace where we also check if a namespace exists before deleting it

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Copy link
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@zeroshade zeroshade merged commit 91c9f99 into apache:main Feb 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants