Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve thread safety and error handling #32

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

xushiyan
Copy link
Member

@xushiyan xushiyan commented Jul 2, 2024

  • adopt Arc and DashMap for file system view, timeline, and table structs
  • change some return types to Result and add handlings

@xushiyan xushiyan added this to the release-0.1.0 milestone Jul 2, 2024
@xushiyan xushiyan changed the title refactor: improve thread safty and error handling refactor: improve thread safety and error handling Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 88.97059% with 15 lines in your changes missing coverage. Please review.

Project coverage is 90.92%. Comparing base (2ac8882) to head (5e7ce28).

Files Patch % Lines
crates/datafusion/src/lib.rs 66.66% 5 Missing ⚠️
crates/core/src/table/mod.rs 89.74% 4 Missing ⚠️
crates/core/src/table/fs_view.rs 93.02% 3 Missing ⚠️
crates/core/src/table/timeline.rs 90.47% 2 Missing ⚠️
crates/core/src/storage/mod.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   92.30%   90.92%   -1.38%     
==========================================
  Files          10       10              
  Lines         468      463       -5     
==========================================
- Hits          432      421      -11     
- Misses         36       42       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xushiyan xushiyan merged commit d5f2231 into apache:main Jul 2, 2024
4 of 6 checks passed
@xushiyan xushiyan deleted the refactor-thread-safty branch July 2, 2024 01:03
@xushiyan xushiyan mentioned this pull request Jul 12, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant