Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enhance Filter and related structs #221

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

xushiyan
Copy link
Member

@xushiyan xushiyan commented Dec 8, 2024

Description

  • Rename PartitionFilter to SchemableFilter for generic use
  • Fix missing Operator::NotEq support
  • Add ergonomic functions for composing Filters, such as col("foo").eq("a")

Closes #160

Follow up #203

How are the changes test-covered

  • N/A
  • Automated tests (unit and/or integration tests)
  • Manual tests
    • Details are described below

@xushiyan xushiyan added refactor Code refactoring without any functionality or behavior change rust Related to Rust codebase labels Dec 8, 2024
@xushiyan xushiyan added this to the release-0.3.0 milestone Dec 8, 2024
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.32%. Comparing base (eb0f520) to head (92857dc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/expr/filter.rs 95.45% 2 Missing ⚠️
crates/datafusion/src/util/expr.rs 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
- Coverage   91.34%   91.32%   -0.02%     
==========================================
  Files          24       24              
  Lines        1074     1095      +21     
==========================================
+ Hits          981     1000      +19     
- Misses         93       95       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xushiyan xushiyan changed the title refactor: enhance Filter and related structs refactor: enhance Filter and related structs Dec 8, 2024
@xushiyan xushiyan merged commit b828538 into apache:main Dec 8, 2024
13 checks passed
@xushiyan xushiyan deleted the refactor-filter branch December 8, 2024 09:09
@xushiyan xushiyan mentioned this pull request Jan 30, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code refactoring without any functionality or behavior change rust Related to Rust codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate with datafusion to support filters pushdown from SQL
1 participant