Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle schema retrieval for datafusion api #187

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

xushiyan
Copy link
Member

Description

Fix DataFusion integration get schema API to handle empty table case - the original Hudi table api returns an Err when retrieving schema fails. The DataFusion API expects a legit SchemaRef to return, so change to return empty schema when Hudi table api gives Err.

Resolves #126

How are the changes test-covered

  • N/A
  • Automated tests (unit and/or integration tests)
  • Manual tests
    • Details are described below

@xushiyan xushiyan added the bug Something isn't working label Nov 20, 2024
@xushiyan xushiyan added this to the release-0.2.0 milestone Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.93%. Comparing base (bf5c6dd) to head (759c01a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   90.81%   90.93%   +0.12%     
==========================================
  Files          20       20              
  Lines         958      960       +2     
==========================================
+ Hits          870      873       +3     
+ Misses         88       87       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@xushiyan xushiyan merged commit 2d94b74 into apache:main Nov 20, 2024
9 checks passed
@xushiyan xushiyan deleted the fix-datafusion-get-schema branch November 20, 2024 07:46
@xushiyan xushiyan restored the fix-datafusion-get-schema branch November 20, 2024 07:46
@xushiyan xushiyan deleted the fix-datafusion-get-schema branch November 20, 2024 07:46
@xushiyan xushiyan mentioned this pull request Nov 22, 2024
9 tasks
@xushiyan xushiyan mentioned this pull request Jan 30, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load empty table failed.
1 participant