fix: write cancel when flush pending write queue #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiKaiWi
force-pushed
the
fix-write-cancel
branch
from
d4e439d to
7a45082
Compare
ShiKaiWi
force-pushed
the
fix-write-cancel
branch
from
7a45082 to
ac37f56
Compare
Closed
jiacai2050
reviewed
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #
Detailed Changes
Currently, the writer for the first request in the pending write queue is responsible for flushing all the writes in the queue, but it can't be ensured to always trigger flush because it may be cancelled when await for the serial exec lock. And this change set replaces the
try_join_allin the rpc services to avoid such cancellation.Test Plan
Test it manually.