feat: filter out MySQL federated components' emitted statements #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunshao90
force-pushed
the
mysql-federated
branch
from
4646ebe to
8a0c395
Compare
chunshao90
force-pushed
the
mysql-federated
branch
from
4fc7134 to
8e6d2a2
Compare
chunshao90
changed the title
chunshao90
force-pushed
the
mysql-federated
branch
from
624f8a4 to
8aff060
Compare
waynexia
previously approved these changes
Jan 15, 2024
Co-authored-by: Yingwen <realevenyag@gmail.com>
evenyag
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Some mysql syntax is not supported, such as
show variables, and user errors will be returned.Detailed Changes
server/src/federated.rsto filter some mysql syntax and return success.server/src/federated.rsinspired by greptime.Support following sql.
scripts/license-header.txt.Test Plan
Add some test and paas CI.