Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore collecting fetched bytes stats when sst file is read only once #1369

Merged
merged 2 commits into from
Dec 15, 2023
Merged

fix: ignore collecting fetched bytes stats when sst file is read only once #1369

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f8e76c
fix: ignore collecting fetched bytes stats when sst file is read only…
ShiKaiWi Dec 15, 2023
322ff59
chore: avoid flag in the ObjectStoreMetricsObserver
ShiKaiWi Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions analytic_engine/src/sst/parquet/async_reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,8 +309,12 @@ impl<'a> Reader<'a> {
);

let mut streams = Vec::with_capacity(target_row_group_chunks.len());
let metrics_collector = ObjectStoreMetricsObserver {
table_level_sst_metrics: self.table_level_sst_metrics.clone(),
let metrics_collector = {
let metrics_for_object_store = matches!(self.frequency, ReadFrequency::Frequent)
.then(|| self.table_level_sst_metrics.clone());
ObjectStoreMetricsObserver {
table_level_sst_metrics: metrics_for_object_store,
}
};
for chunk in target_row_group_chunks {
let object_store_reader = ObjectStoreReader::with_metrics(
Expand Down Expand Up @@ -763,18 +767,20 @@ impl<'a> SstReader for ThreadedReader<'a> {

#[derive(Clone)]
struct ObjectStoreMetricsObserver {
table_level_sst_metrics: Arc<MaybeTableLevelMetrics>,
table_level_sst_metrics: Option<Arc<MaybeTableLevelMetrics>>,
}

impl MetricsObserver for ObjectStoreMetricsObserver {
fn elapsed(&self, path: &Path, elapsed: Duration) {
debug!("ObjectStoreReader dropped, path:{path}, elapsed:{elapsed:?}",);
debug!("ObjectStoreReader dropped, path:{path}, elapsed:{elapsed:?}");
}

fn num_bytes_fetched(&self, _: &Path, num_bytes: usize) {
self.table_level_sst_metrics
.num_fetched_sst_bytes
.fetch_add(num_bytes as u64, Ordering::Relaxed);
if let Some(metrics) = &self.table_level_sst_metrics {
metrics
.num_fetched_sst_bytes
.fetch_add(num_bytes as u64, Ordering::Relaxed);
}
}
}

Expand Down