refactor: remove unused min/max timestamp in the RowGroup

analytic_engine/src/instance/write.rs

@@ -712,7 +712,7 @@ mod tests {
     use common_types::{
         column_schema::Builder as ColumnSchemaBuilder,
         datum::{Datum, DatumKind},
-        row::{Row, RowGroupBuilder},
+        row::Row,
         schema::Builder as SchemaBuilder,
         time::Timestamp,
     };
@@ -737,7 +737,7 @@ mod tests {
             .unwrap()
             .build()
             .unwrap();
-        let row_group = RowGroupBuilder::with_rows(schema, rows).unwrap().build();
+        let row_group = RowGroup::new_checked(schema, rows).unwrap();
 
         (encoded_rows, row_group)
     }

analytic_engine/src/payload.rs

@@ -22,7 +22,7 @@ use codec::{
     Decoder,
 };
 use common_types::{
-    row::{RowGroup, RowGroupBuilder, RowGroupBuilderFromColumn},
+    row::{RowGroup, RowGroupBuilderFromColumn},
     schema::Schema,
     table::TableId,
 };
@@ -202,18 +202,19 @@ impl ReadPayload {
 
         // Consume and convert rows in pb
         let encoded_rows = write_req_pb.rows;
-        let mut builder = RowGroupBuilder::with_capacity(schema.clone(), encoded_rows.len());
+        let mut rows = Vec::with_capacity(encoded_rows.len());
         let row_decoder = WalRowDecoder::new(&schema);
         for row_bytes in &encoded_rows {
             let row = row_decoder
                 .decode(&mut row_bytes.as_slice())
                 .context(DecodeRow)?;
             // We skip schema check here
-            builder.push_checked_row(row);
+            rows.push(row);
         }
 
-        let row_group = builder.build();
-
+        // The `rows` are decoded according to the schema, so there is no need to do one
+        // more check here.
+        let row_group = RowGroup::new_unchecked(schema, rows);
         Ok(Self::Write { row_group })
     }
 

analytic_engine/src/table/mod.rs

@@ -22,7 +22,7 @@ use std::{
 
 use async_trait::async_trait;
 use common_types::{
-    row::{Row, RowGroupBuilder},
+    row::{Row, RowGroup},
     schema::Schema,
     time::TimeRange,
 };
@@ -251,20 +251,19 @@ fn merge_pending_write_requests(
     assert!(!pending_writes.is_empty());
 
     let mut last_req = pending_writes.pop().unwrap();
-    let last_rows = last_req.row_group.take_rows();
-    let schema = last_req.row_group.into_schema();
-    let mut row_group_builder = RowGroupBuilder::with_capacity(schema, num_pending_rows);
-
-    for mut pending_req in pending_writes {
-        let rows = pending_req.row_group.take_rows();
-        for row in rows {
-            row_group_builder.push_checked_row(row)
+    let total_rows = {
+        let mut rows = Vec::with_capacity(num_pending_rows);
+        for mut pending_req in pending_writes {
+            let mut pending_rows = pending_req.row_group.take_rows();
+            rows.append(&mut pending_rows);
         }
-    }
-    for row in last_rows {
-        row_group_builder.push_checked_row(row);
-    }
-    let row_group = row_group_builder.build();
+        let mut last_rows = last_req.row_group.take_rows();
+        rows.append(&mut last_rows);
+        rows
+    };
+
+    let schema = last_req.row_group.into_schema();
+    let row_group = RowGroup::new_unchecked(schema, total_rows);
     WriteRequest { row_group }
 }
 
@@ -652,7 +651,7 @@ mod tests {
             schema_rows.push(row);
         }
         let rows = row_util::new_rows_6(&schema_rows);
-        let row_group = RowGroupBuilder::with_rows(schema, rows).unwrap().build();
+        let row_group = RowGroup::new_checked(schema, rows).unwrap();
         WriteRequest { row_group }
     }
 

analytic_engine/src/tests/alter_test.rs

@@ -19,7 +19,7 @@ use std::collections::{BTreeMap, HashMap};
 use common_types::{
     column_schema,
     datum::DatumKind,
-    row::{RowGroup, RowGroupBuilder},
+    row::RowGroup,
     schema::{self, Schema},
     time::Timestamp,
 };
@@ -227,9 +227,7 @@ async fn alter_schema_add_column_case<T: WalsOpener>(
         ),
     ];
     let rows_vec = row_util::new_rows_8(&rows);
-    let row_group = RowGroupBuilder::with_rows(new_schema.clone(), rows_vec)
-        .unwrap()
-        .build();
+    let row_group = RowGroup::new_checked(new_schema.clone(), rows_vec).unwrap();
 
     // Write data with new schema.
     test_ctx.write_to_table(table_name, row_group).await;
@@ -283,9 +281,7 @@ async fn alter_schema_add_column_case<T: WalsOpener>(
         )),
     ];
     let new_schema_row_group =
-        RowGroupBuilder::with_rows(new_schema.clone(), new_schema_rows.to_vec())
-            .unwrap()
-            .build();
+        RowGroup::new_checked(new_schema.clone(), new_schema_rows.to_vec()).unwrap();
 
     // Read data using new schema.
     check_read_row_group(
@@ -332,9 +328,8 @@ async fn alter_schema_add_column_case<T: WalsOpener>(
         ),
     ];
     let old_schema_rows_vec = row_util::new_rows_6(&old_schema_rows);
-    let old_schema_row_group = RowGroupBuilder::with_rows(old_schema.clone(), old_schema_rows_vec)
-        .unwrap()
-        .build();
+    let old_schema_row_group =
+        RowGroup::new_checked(old_schema.clone(), old_schema_rows_vec).unwrap();
 
     // Read data using old schema.
     check_read_row_group(

analytic_engine/src/tests/table.rs

@@ -22,7 +22,7 @@ use common_types::{
     projected_schema::ProjectedSchema,
     record_batch::RecordBatch,
     request_id::RequestId,
-    row::{Row, RowGroup, RowGroupBuilder},
+    row::{Row, RowGroup},
     schema::{self, Schema},
     table::DEFAULT_SHARD_ID,
     time::Timestamp,
@@ -122,9 +122,7 @@ impl FixedSchemaTable {
     }
 
     fn new_row_group(&self, rows: Vec<Row>) -> RowGroup {
-        RowGroupBuilder::with_rows(self.create_request.params.table_schema.clone(), rows)
-            .unwrap()
-            .build()
+        RowGroup::new_checked(self.create_request.params.table_schema.clone(), rows).unwrap()
     }
 
     fn new_row_opt(data: RowTupleOpt) -> Row {