feat: store real time range in sst #1225
Merged
+135
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
force-pushed
the
feat-sst-timerange
branch
from
9e080cf to
5998451
Compare
jiacai2050
force-pushed
the
feat-sst-timerange
branch
3 times, most recently
from
ae51d40 to
3fab845
Compare
chunshao90
reviewed
Sep 25, 2023
This was referenced Sep 26, 2023
chunshao90
pushed a commit
that referenced
this pull request
Sep 30, 2023
## Rationale Followup PR of #1225, this PR add the same logic for memtable. ## Detailed Changes ## Test Plan Integration tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Currently CeresDB will store aligned time range when write SST, this will cause IO amplification for certain query.
For example, the SST only contains one row, and its timestamp is 10:01, its time range in metadata will be aligned to
[10:00, 12:00), if query contains filter liketimestamp > 10:01, currently query plan will include this SST, but in fact we could skip this SST to avoid unnecessary IO.Detailed Changes
Test Plan