Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: record remote engine requests #1140

Merged
merged 3 commits into from
Aug 8, 2023
Merged

fix: record remote engine requests #1140

merged 3 commits into from
Aug 8, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Aug 7, 2023 •
edited
Loading

Rationale

#1127 add support for remote engine, but in client, it should be for server.

Detailed Changes

  • Remove remote client record, add add for remote server.

Test Plan

Manually

ShiKaiWi
ShiKaiWi approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit b69f82d into apache:main Aug 8, 2023
@jiacai2050 jiacai2050 deleted the fix-recorder branch August 8, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShiKaiWi ShiKaiWi ShiKaiWi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiacai2050 @ShiKaiWi