Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add actual scan duration stats into chain iterator #1109

Merged
merged 2 commits into from
Jul 27, 2023
Merged

chore: add actual scan duration stats into chain iterator #1109

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18b9940
add actual scan duration stats into chain iterator.
Rachelint Jul 27, 2023
88d8eb6
modify the stats way for scan duration.
Rachelint Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 32 additions & 19 deletions analytic_engine/src/row_iter/chain.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,9 @@ struct Metrics {
/// Inited time of the iterator.
#[metric(duration)]
since_init: Duration,
/// Actual scan duration.
#[metric(duration)]
scan_duration: Duration,
#[metric(collector)]
metrics_collector: Option<MetricsCollector>,
}
Expand All @@ -223,6 +226,7 @@ impl Metrics {
total_rows_fetched: 0,
since_create: Duration::default(),
since_init: Duration::default(),
scan_duration: Duration::default(),
metrics_collector,
}
}
Expand All @@ -237,6 +241,7 @@ impl fmt::Debug for Metrics {
.field("total_rows_fetched", &self.total_rows_fetched)
.field("duration_since_create", &self.since_create)
.field("duration_since_init", &self.since_init)
.field("scan_duration", &self.scan_duration)
.finish()
}
}
Expand Down Expand Up @@ -289,26 +294,8 @@ impl ChainIterator {
self.next_prefetch_stream_idx += 1;
}
}
}

impl Drop for ChainIterator {
fn drop(&mut self) {
debug!(
"Chain iterator dropped, space_id:{}, table_id:{:?}, request_id:{}, inited_at:{:?}, metrics:{:?}",
self.space_id, self.table_id, self.request_id, self.inited_at, self.metrics,
);
}
}

#[async_trait]
impl RecordBatchWithKeyIterator for ChainIterator {
type Error = Error;

fn schema(&self) -> &RecordSchemaWithKey {
&self.schema
}

async fn next_batch(&mut self) -> Result<Option<RecordBatchWithKey>> {
async fn next_batch_internal(&mut self) -> Result<Option<RecordBatchWithKey>> {
self.init_if_necessary();
self.maybe_prefetch().await;

Expand Down Expand Up @@ -348,6 +335,32 @@ impl RecordBatchWithKeyIterator for ChainIterator {
}
}

impl Drop for ChainIterator {
fn drop(&mut self) {
debug!(
"Chain iterator dropped, space_id:{}, table_id:{:?}, request_id:{}, inited_at:{:?}, metrics:{:?}",
self.space_id, self.table_id, self.request_id, self.inited_at, self.metrics,
);
}
}

#[async_trait]
impl RecordBatchWithKeyIterator for ChainIterator {
type Error = Error;

fn schema(&self) -> &RecordSchemaWithKey {
&self.schema
}

async fn next_batch(&mut self) -> Result<Option<RecordBatchWithKey>> {
let timer = Instant::now();
let res = self.next_batch_internal().await;
self.metrics.scan_duration += timer.elapsed();

res
}
}

#[cfg(test)]
mod tests {
use common_types::{
Expand Down