Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add testcases for time range predicate #1078

Merged
merged 4 commits into from
Jul 17, 2023
Merged

chore: add testcases for time range predicate #1078

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b42704
chroe: add testcase for time range predicate
tanruixiang Jul 17, 2023
b8d2855
add comment
tanruixiang Jul 17, 2023
20947ce
add testcase
tanruixiang Jul 17, 2023
894fab1
add testcase
tanruixiang Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
137 changes: 137 additions & 0 deletions table_engine/src/predicate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,3 +426,140 @@ impl<'a> TimeRangeExtractor<'a> {
}
}
}

#[cfg(test)]
mod tests {
use common_types::{
tests::build_schema_with_dictionary,
time::{TimeRange, Timestamp},
};
use datafusion::{
prelude::{col, Expr},
scalar::ScalarValue,
};

use crate::predicate::PredicateBuilder;

fn set_timestamp(ts: i64) -> Expr {
Expr::Literal(ScalarValue::TimestampMillisecond(Some(ts), None))
}
#[test]
fn test_extract_range() {
// The actual range needs to be a subset of the predicate range
let schema = build_schema_with_dictionary();
let cases = vec![
(
// key2 > 10000
col("key2").gt(set_timestamp(10000)),
TimeRange::new(Timestamp::new(10001), Timestamp::MAX).unwrap(),
),
(
// key2 > 10000 and key2 > 500
col("key2")
.gt(set_timestamp(10000))
.and(col("key2").gt(set_timestamp(500))),
TimeRange::new(Timestamp::new(10001), Timestamp::MAX).unwrap(),
),
(
// key2 > 10000 or key2 > 500
col("key2")
.gt(set_timestamp(10000))
.or(col("key2").gt(set_timestamp(500))),
TimeRange::new(Timestamp::new(501), Timestamp::MAX).unwrap(),
),
(
// key2 > 10000 or (key2 > 500 and key2 > 300)
col("key2").gt(set_timestamp(10000)).or(col("key2")
.gt(set_timestamp(500))
.and(col("key2").gt(set_timestamp(300)))),
TimeRange::new(Timestamp::new(501), Timestamp::MAX).unwrap(),
),
(
// key2 > 10000 or (key2 > 500 and key2 < 600)
col("key2").gt(set_timestamp(10000)).or(col("key2")
.gt(set_timestamp(500))
.and(col("key2").lt(set_timestamp(600)))),
TimeRange::new(Timestamp::new(501), Timestamp::MAX).unwrap(),
),
(
// key2 > 500 and key2 < 600
col("key2")
.gt(set_timestamp(500))
.and(col("key2").lt(set_timestamp(600))),
TimeRange::new(Timestamp::new(501), Timestamp::new(600)).unwrap(),
),
(
// key2 > 10000 and (key2 > 500 and key2 < 600)
col("key2").gt(set_timestamp(10000)).and(
col("key2")
.gt(set_timestamp(500))
.and(col("key2").lt(set_timestamp(600))),
),
TimeRange::new(Timestamp::new(0), Timestamp::new(0)).unwrap(),
),
(
// key2 > 10000 and (key2 > 500 and key2 > 600)
col("key2").gt(set_timestamp(10000)).and(
col("key2")
.gt(set_timestamp(500))
.and(col("key2").gt(set_timestamp(600))),
),
TimeRange::new(Timestamp::new(10001), Timestamp::MAX).unwrap(),
),
(
// key2 > 10 and (key2 < 500 and key2 > 1)
col("key2").gt(set_timestamp(10)).and(
col("key2")
.lt(set_timestamp(500))
.and(col("key2").gt(set_timestamp(1))),
),
TimeRange::new(Timestamp::new(11), Timestamp::new(500)).unwrap(),
),
(
// key2 < 10 and key2 > 11
col("key2")
.lt(set_timestamp(10))
.and(col("key2").gt(set_timestamp(11))),
TimeRange::new(Timestamp::new(0), Timestamp::new(0)).unwrap(),
),
(
// key2 < 10 or key2 > 11
col("key2")
.lt(set_timestamp(10))
.or(col("key2").gt(set_timestamp(11))),
TimeRange::new(Timestamp::MIN, Timestamp::MAX).unwrap(),
),
(
// (key2 < 10 or key2 > 11) and key2 > 1000
(col("key2")
.lt(set_timestamp(10))
.or(col("key2").gt(set_timestamp(11))))
.and(col("key2").gt(set_timestamp(1000))),
TimeRange::new(Timestamp::new(1001), Timestamp::MAX).unwrap(),
),
(
// (key2 > 10 or key2 > 100) and key2 > 5
(col("key2")
.lt(set_timestamp(10))
.or(col("key2").gt(set_timestamp(100))))
.and(col("key2").gt(set_timestamp(5))),
TimeRange::new(Timestamp::new(6), Timestamp::MAX).unwrap(),
),
(
// (key2 > 1 or key2 > 100) and key2 > 5
(col("key2")
.lt(set_timestamp(10))
.or(col("key2").gt(set_timestamp(100))))
.and(col("key2").gt(set_timestamp(5))),
TimeRange::new(Timestamp::new(6), Timestamp::MAX).unwrap(),
),
];
for (expr, expcted) in cases {
let predict = PredicateBuilder::default()
.add_pushdown_exprs(&vec![expr.clone()])
.extract_time_range(&schema, &vec![expr])
.build();
assert_eq!(predict.time_range(), expcted);
}
}
}