FINERACT-2181: Fix accrual activity reversal logic: prevent duplicate reverse-replay, copy external ID correctly #4430
+463
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksii-novikov-onix
force-pushed
the
bugfix/FINERACT-2181-accrual-activity-reverse-replay
branch
from
5be1775 to
8feb629
Compare
| loanAccountService.saveLoanTransactionWithDataIntegrityViolationChecks(newLoanTransaction); | ||
| loan.addLoanTransaction(newLoanTransaction); | ||
|
|
||
| LoanAdjustTransactionBusinessEvent.Data data = new LoanAdjustTransactionBusinessEvent.Data(loanTransaction); | ||
| data.setNewTransactionDetail(newLoanTransaction); | ||
| businessEventNotifierService.notifyPostBusinessEvent(new LoanAdjustTransactionBusinessEvent(data)); | ||
| } else { | ||
| reverseAccrualActivityTransaction(loanTransaction); |
There was a problem hiding this comment.
Shouldn't we also updateExternalId for loanTransaction in this method (reverseAccrualActivityTransaction)?
There was a problem hiding this comment.
I was asking myself the same question, but it turns out that updateExternalId(null) was removed here.
@adamsaghy , please take a look.
ruzeynalov
approved these changes
Mar 7, 2025
peter-kovacs-dpc
force-pushed
the
bugfix/FINERACT-2181-accrual-activity-reverse-replay
branch
from
8feb629 to
227aa7c
Compare
oleksii-novikov-onix
force-pushed
the
bugfix/FINERACT-2181-accrual-activity-reverse-replay
branch
from
227aa7c to
60d7e38
Compare
adamsaghy
reviewed
Mar 7, 2025
| @@ -198,7 +199,8 @@ private void loanAccountDataV1Check(Class<? extends AbstractLoanEvent> eventClaz | |||
| Long clientIdExpected = body.getClientId(); | |||
| BigDecimal principalDisbursedActual = loanAccountDataV1.getSummary().getPrincipalDisbursed(); | |||
| Double principalDisbursedExpectedDouble = body.getSummary().getPrincipalDisbursed(); | |||
| BigDecimal principalDisbursedExpected = new BigDecimal(principalDisbursedExpectedDouble, MathContext.DECIMAL64); | |||
| BigDecimal principalDisbursedExpected = new BigDecimal(principalDisbursedExpectedDouble, MathContext.DECIMAL64) | |||
There was a problem hiding this comment.
why the hardcoded hald_down? This looks incorrect to me
… reverse-replay, copy external ID correctly
… duplicate reverse-replay, copy external ID correctly Based on the work of @tamasszabo-dpc and @peter-kovacs-dpc
adamsaghy
force-pushed
the
bugfix/FINERACT-2181-accrual-activity-reverse-replay
branch
from
d2cb57f to
3ef6de4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.