Upgrade to latest jline release and enable the gogo-build #390
+15
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So you basically reimplemented JLine properties As @gnodet said, everything can be tuned with system properties in JLine3 already. Also, why not latest JLine3? |
laeubi
force-pushed
the
support_color_mode
branch
2 times, most recently
from
f223995 to
f268a41
Compare
laeubi
changed the title
gnodet
reviewed
Mar 6, 2025
| @@ -683,7 +684,7 @@ public List<Candidate> __files(CommandSession session) { | |||
| List<Candidate> candidates = new ArrayList<>(); | |||
| new FilesCompleter(session.currentDir()) { | |||
| @Override | |||
| protected String getDisplay(Terminal terminal, Path p) { | |||
| protected String getDisplay(Terminal terminal, Path p, StyleResolver resolver, String separator) { | |||
There was a problem hiding this comment.
The indentation looks weird.
| @@ -696,7 +697,7 @@ public List<Candidate> __directories(CommandSession session) { | |||
| List<Candidate> candidates = new ArrayList<>(); | |||
| new DirectoriesCompleter(session.currentDir()) { | |||
| @Override | |||
| protected String getDisplay(Terminal terminal, Path p) { | |||
| protected String getDisplay(Terminal terminal, Path p, StyleResolver resolver, String separator) { | |||
There was a problem hiding this comment.
The indentation looks weird.
|
Looks good! Some formatting maybe... |
Currently gogo-jline uses a rather outdated jline release, this upgrades to the latest release and enables the build.
laeubi
force-pushed
the
support_color_mode
branch
from
f268a41 to
ce69e26
Compare
|
The build just failed on the branch build. Probably one of the other projects in the pom needs looking into as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently gogo-jline uses a rather outdated jline release, this upgrades to the latest release and enables the build.