Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-3625]Add constant 'MIN_PATH_ARRAY_LENGTH' #3679

Closed
wants to merge 1 commit into from

Conversation

John-Smile
Copy link
Contributor

@John-Smile John-Smile commented Mar 16, 2019

Fixes #3625.

What is the purpose of the change

Remove magic number in org.apache.dubbo.configcenter.support.zookeeper.CacheListener#childEvent

Brief changelog

Add constant 'MIN_PATH_ARRAY_LENGTH'.

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@John-Smile John-Smile closed this Mar 16, 2019
@John-Smile
Copy link
Contributor Author

Conflicts with new commits.

@John-Smile John-Smile deleted the dev_fix_magic_number branch March 16, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Magic number in CacheListener
1 participant