Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove startupProbe in kubernetes-overlord-extensions #17784

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

applike-ss
Copy link

Partially Fixes #17783.

Description

The readiness and liveness probes are removed, however the startup probe remains - which makes peon tasks never get healthy and kills them after not coming up long enough.

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

Release note

Removed Startup probe in kubernetes-overlord-extentions, so that peon tasks can start up properly without being killed by kubernetes.


Key changed/added classes in this PR
  • remove startup probe on peon tasks, if it exists

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Signed-off-by: Sebastian Struß <struss@justtrack.io>
Copy link
Contributor

@georgew5656 georgew5656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, if you have time could you add a unit test checking this behavior?

Signed-off-by: Sebastian Struß <struss@justtrack.io>
@applike-ss
Copy link
Author

I have added a unit test, but i can't execute it on my end because IntelliJ IDEA can't resolve org.apache.druid.math.expr.antlr.ExprBaseListener and org.apache.druid.math.expr.antlr.ExprParser.

Maybe you can try it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MM-less with overlordSingleContainer type adds wrong startup probe for peon task
2 participants