remove NullValueHandlingConfig, NullHandlingModule, NullHandling #17778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianm
approved these changes
Mar 5, 2025
|
Sorry 😓 ! This PR seems to have merge conflicts now since I merged #17776 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After #17634, the
NullValueHandlingConfigis not actually required for anything anymore sincePropertiesValidatoris now doing the checks for the removed config values being set, so no need to materialize it into JSON config, so this PR removes it and the associated module.NullHandling.IS_NULL_BYTE/NullHandling.IS_NOT_NULL_BYTEare nowTypeStrategies.IS_NULL_BYTE/TypeStrategies.IS_NOT_NULL_BYTEsince it seemed kind of silly to keepNullHandlingaround for 2 static constants, but I can move them back if anyone is worried about this being disruptive for extensions or whatever.