Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Remove unused SQLIntegrityConstraintViolationException in JdbcOperator #16200

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

ruanwenjun
Copy link
Member

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_removeUnusedException branch 2 times, most recently from 0ab584c to 4bc3192 Compare June 24, 2024 05:48
@ruanwenjun ruanwenjun changed the title Remove unused SQLIntegrityConstraintViolationException in JdbcOperator [Chore] Remove unused SQLIntegrityConstraintViolationException in JdbcOperator Jun 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.01%. Comparing base (b34fe46) to head (f6e877d).

Current head f6e877d differs from pull request most recent head 01fe97a

Please upload reports for the commit 01fe97a to get more accurate results.

Files Patch % Lines
...inscheduler/plugin/registry/jdbc/JdbcOperator.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #16200      +/-   ##
============================================
- Coverage     41.02%   41.01%   -0.01%     
+ Complexity     5161     5157       -4     
============================================
  Files          1400     1400              
  Lines         44860    44860              
  Branches       4746     4747       +1     
============================================
- Hits          18402    18398       -4     
- Misses        24651    24656       +5     
+ Partials       1807     1806       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_removeUnusedException branch from 4bc3192 to 0dd8ebb Compare June 24, 2024 07:16
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SbloodyS SbloodyS added the 3.3.0 label Jun 24, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Jun 24, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
51.8% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

@ruanwenjun ruanwenjun requested a review from EricGao888 June 24, 2024 13:46
Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickchengx rickchengx merged commit f69e064 into apache:dev Jun 25, 2024
63 of 64 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_removeUnusedException branch November 23, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants