-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] Abnormal characters check #15824
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please link this pr to your issue and fix CI. @pinkfloyds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, please Run 'mvn spotless:apply' to fix the code style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15824 +/- ##
============================================
- Coverage 39.24% 39.24% -0.01%
Complexity 4910 4910
============================================
Files 1323 1323
Lines 45187 45191 +4
Branches 4811 4812 +1
============================================
+ Hits 17734 17735 +1
- Misses 25572 25573 +1
- Partials 1881 1883 +2 ☔ View full report in Codecov by Sentry. |
|
This reverts commit e5e7749.
Purpose of the pull request
resource center file path illegal character check filter ,added checkFilePath() in checkFullName()
Brief change log
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/CheckUtils.java
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ResourcesServiceImpl.java
Verify this pull request
Manually verified the change by testing locally.
Added test case testCheckFilePath in CheckUtilsTest.