Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement-15744][parameter] project parameter add update time and update user id #15745

Merged
merged 14 commits into from
Apr 2, 2024

Conversation

sdhzwc
Copy link
Contributor

@sdhzwc sdhzwc commented Mar 20, 2024

fix #15744

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@sdhzwc sdhzwc requested a review from EricGao888 as a code owner March 21, 2024 02:09
@SbloodyS SbloodyS added improvement make more easy to user or prompt friendly 3.2.2 labels Mar 21, 2024
@SbloodyS SbloodyS added this to the 3.2.2 milestone Mar 21, 2024
@caishunfeng
Copy link
Contributor

caishunfeng commented Mar 21, 2024

Hi @sdhzwc it's not a bugfix pr, please change the pr title prefix to [Improvement-15698], thanks.

see https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md

@sdhzwc sdhzwc changed the title [Fix-15698][parameter] project parameter add update time and update user id [Improvement-15698][parameter] project parameter add update time and update user id Mar 21, 2024
@sdhzwc sdhzwc changed the title [Improvement-15698][parameter] project parameter add update time and update user id [Improvement-15744][parameter] project parameter add update time and update user id Mar 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.19%. Comparing base (8acc697) to head (6fcc7ab).

❗ Current head 6fcc7ab differs from pull request most recent head 75707cb. Consider uploading reports for the commit 75707cb to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #15745   +/-   ##
=========================================
  Coverage     39.18%   39.19%           
+ Complexity     4876     4875    -1     
=========================================
  Files          1317     1317           
  Lines         45037    45039    +2     
  Branches       4808     4808           
=========================================
+ Hits          17649    17651    +2     
+ Misses        25502    25501    -1     
- Partials       1886     1887    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdhzwc
Copy link
Contributor Author

sdhzwc commented Mar 21, 2024

Hi @sdhzwc it's not a bugfix pr, please change the pr title prefix to [Improvement-15698], thanks.

see https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md

Adjustments have been made

@qingwli
Copy link
Member

qingwli commented Mar 22, 2024

Hi @sdhzwc , How to see this projectParameter.Operator in ui?

@github-actions github-actions bot added the UI ui and front end related label Mar 23, 2024
@sdhzwc
Copy link
Contributor Author

sdhzwc commented Mar 23, 2024

Hi @sdhzwc , How to see this projectParameter.Operator in ui?

image
image

The UI has added a Create User and Modify User display

Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@qingwli qingwli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link

sonarqubecloud bot commented Apr 2, 2024

@SbloodyS SbloodyS merged commit 920ac15 into apache:dev Apr 2, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.2 backend improvement make more easy to user or prompt friendly ready-to-merge UI ui and front end related
Projects
None yet
9 participants