Fix: regularize order bys when consuming from substrait #14125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Thank you @gabotechs
The code looks good to me and I verified that this test fails without the code changes in this PR.
assertion `left == right` failed
left: 0
right: 1
|
Thanks again @gabotechs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No issue added, let me know if one is needed
Rationale for this change
Fixing an issue with the current substrait consumer
What changes are included in this PR?
Using built-in method for regularizing order by statements based on window frames in the substrait consumer
Are these changes tested?
Yes
Are there any user-facing changes?
Anyone that is passing substrait plans directly to DataFusion should be able to pass window function nodes with no order bys and with a "RANGE" window frame unit.