Use UUID to create unique table names in python binding #1111
Conversation
python/src/context.rs
Outdated
| .chain(rand::thread_rng().sample_iter(&Alphanumeric)) | ||
| .take(10) | ||
| .collect::<String>(); | ||
| let name = "c".to_owned() + &Uuid::new_v4().to_simple().to_string(); |
There was a problem hiding this comment.
can you help add unit test? also the to_simple seems to produce upper case string
There was a problem hiding this comment.
@jimexist Thank you for your comment. I have added another commit with two changes - convert UUID table name part to lower case and also I added a test (in Python) to ensure that create_dataframe() registers newly created table and its table name is as expected.
If you are ok with the change, I will squash the commits to clean the branch before the merge.
There was a problem hiding this comment.
You don't need to squash from your end if you prefer not to. We always do squash merge for our PRs anyway.
…at create_dataframe registers new table with expected name
|
@hippowdon looks like there is a linter failure that needs to be addressed. |
|
Apologies that I did not run flake8 before committing Python code. The last commit is clean from flake8'e point of view. |
|
Thanks @hippowdon for the quick fix :) |
Which issue does this PR close?
Closes #1106
Ensure truly unique table names.
uuid crate is included into Cargo.toml