Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plain JOIN without turning it into INNER #1692

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

mvzink
Copy link
Contributor

@mvzink mvzink commented Jan 30, 2025

Although these are syntactic equivalents in some dialects, we can preserve the input syntax without less rewriting this way.

Although these are syntactic equivalents in some dialects, we can
preserve the input syntax without less rewriting this way.
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @mvzink!
cc @alamb

@iffyio iffyio merged commit 252fdba into apache:main Jan 30, 2025
9 checks passed
@mvzink mvzink deleted the plain-join branch January 30, 2025 16:05
Vedin pushed a commit to Embucket/datafusion-sqlparser-rs that referenced this pull request Feb 3, 2025
Vedin pushed a commit to Embucket/datafusion-sqlparser-rs that referenced this pull request Feb 3, 2025
Vedin added a commit to Embucket/datafusion-sqlparser-rs that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants