Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: bump node engine requirement >=20.5.0 #1789

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

erisu
Copy link
Member

@erisu erisu commented Mar 18, 2025

Motivation and Context

Bump node engine requirement to >=20.5.0

Description

  • nopt, which being bumped to 8.1.0 in PR dep!: bump npm packages #1788 will increase the node engine requirement to ^18.17.0 || >=20.5.0.
  • Node 18 will be reaching its EOL sometime next month (April), so we will set the node engine requirement to >=20.5.0.

Testing

  • npm t

Checklist

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.89%. Comparing base (ff11f65) to head (8198b5e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1789   +/-   ##
=======================================
  Coverage   71.89%   71.89%           
=======================================
  Files          23       23           
  Lines        1854     1854           
=======================================
  Hits         1333     1333           
  Misses        521      521           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dpogue
Copy link
Member

dpogue commented Mar 18, 2025

This should also drop node 16 and 18 from CI, right?

@breautek
Copy link
Contributor

breautek commented Mar 18, 2025

Is there a particular reason for >=20.5.0, instead of 20.x?

Like is there a reason that requires at least 20.5?

EDIT: I misinterpreted, I understand now that it's due to a dependency 👍

@erisu erisu merged commit 7ab1848 into apache:master Mar 19, 2025
8 checks passed
@erisu erisu deleted the feat/bump-node-engine-requirement branch March 19, 2025 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants