-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add AndroidEdgeToEdge preference & theme flag #1779
Conversation
Note that because Edge-To-Edge is disabled by default, You can opt-in to working |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1779 +/- ##
==========================================
- Coverage 72.50% 72.00% -0.51%
==========================================
Files 23 23
Lines 1837 1850 +13
==========================================
Hits 1332 1332
- Misses 505 518 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Just a note that the
|
Last call for reviews before merging in. |
I do sortof question if it's worth merging this knowing that it's going to be deprecated immediately in the next release. Unfortunately there aren't really any alternatives at the moment, so it's probably better to have something than nothing :\ |
18b0e61
to
e035e4e
Compare
Motivation and Context
In the next Cordova-Android release, we will temporarily disable the Edge-to-Edge feature to maintain the same behavior that existed previously. The new feature appears to have issues with safe-area-*.
When setting
viewport-fit
toauto
orcontain
, the content will render behind the safe-area which is believed to be an unintended behavior. iOS for example will automatically render the content below the statusbar.Description
android:windowOptOutEdgeToEdgeEnforcement
and default totrue
AndroidEdgeToEdge
to allow changing of the theme flagAndroidEdgeToEdge
is set totrue
,android:windowOptOutEdgeToEdgeEnforcement
will befalse
AndroidEdgeToEdge
is set tofalse
, an empty string, not defined, or invalid entry,windowOptOutEdgeToEdgeEnforcement
will betrue
Testing
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)