Migrate public templates that have URLs on data migration across secondary storages #10364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blueorangutan package |
|
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10364 +/- ##
=============================================
- Coverage 16.02% 4.01% -12.02%
=============================================
Files 5658 395 -5263
Lines 496312 32452 -463860
Branches 60109 5743 -54366
=============================================
- Hits 79536 1302 -78234
+ Misses 407927 31001 -376926
+ Partials 8849 149 -8700
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12402 |
...age/image/src/main/java/org/apache/cloudstack/storage/image/SecondaryStorageServiceImpl.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, data migration across secondary storages does not migrate public templates that have URLs (only private templates and public templates that do not have URLs are migrated) because, when this feature was implemented, it was assumed that these templates would automatically be downloaded when to newly added secondary storages. However, that's not always the case, as URLs can become inaccessible (unable to download the template), and their templates can be updated (unable to install due to checksum mismatch). This forces operators to manually move the templates inside the storage.
This PR solves this issue by allowing the migration of public templates that have URLs.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
How Has This Been Tested?
In an environment with the following templates:
a,b,ctSystem VM Template (KVM),zAnd two secondary storages:
nfs-1: has all the templatesnfs-2: hasb,c(all public templates excepta)I did the following tests:
I restarted the SSVM. Then, I verified that it began to download templates
aandSystem VM Template (KVM)tonfs-2While the templates were downloading, I called
migrateSecondaryStorageDatato migrate the data fromnfs-1tonfs-2After the migration ended, I verified that all templates in
nfs-1were moved tonfs-2. I also verified that there were no duplicate template entries, and that theinstall_pathof the new entries matched the template's path innfs-2