Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref #534: Remove docker images on exit #536

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

essobedo
Copy link
Contributor

@essobedo essobedo commented Oct 22, 2024

fixes #534

Motivation

The build runs out of disk space which prevents adding new integration tests

Modifications:

  • Free up some disk space by:
    • following the workaround described in this ticket
    • removing pre-pulled docker images
  • Add a new System property camel.karaf.itest.keep.docker.images to indicate whether the docker images should be removed after the test. Locally, you can leverage the Maven property keep.docker.images.on.exit to keep them or not. By default, the docker images are cleaned up to prevent the disk space leak
  • Extend the forked process exit timeout to ensure that pax-exam can stop properly

Results

Without these changes, we had 21 Gb available for the build and 0 Gb available after.
With these changes, we have 35 Gb available for the build and 23 Gb available after.

@essobedo essobedo force-pushed the essobedo/534/free-space branch 2 times, most recently from 9dbab1c to 5162063 Compare October 22, 2024 16:13
@essobedo essobedo force-pushed the essobedo/534/free-space branch 2 times, most recently from 0ed5b9a to cfcd214 Compare October 22, 2024 16:25
@essobedo essobedo changed the title Ref #534: Build runs out of space Ref #534: Free disk space Oct 22, 2024
@essobedo essobedo force-pushed the essobedo/534/free-space branch 6 times, most recently from 39dbb35 to 0d6c348 Compare October 23, 2024 10:18
@essobedo essobedo changed the title Ref #534: Free disk space Ref #534: Remove docker images on exit Oct 23, 2024
@essobedo essobedo marked this pull request as ready for review October 23, 2024 10:32
@essobedo essobedo force-pushed the essobedo/534/free-space branch from 0d6c348 to 3ebe2cd Compare October 23, 2024 11:15
Copy link
Collaborator

@f2par0 f2par0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@essobedo essobedo merged commit a308c55 into main Oct 23, 2024
1 check passed
@essobedo essobedo deleted the essobedo/534/free-space branch October 23, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build runs out of space
3 participants