Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify BigQuery InsertRetryPolicy behavior for non-200 responses #34118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −1
Open

Clarify BigQuery InsertRetryPolicy behavior for non-200 responses #34118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion ...e-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/InsertRetryPolicy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,22 @@
import java.util.Set;
import org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.collect.ImmutableSet;

/** A retry policy for streaming BigQuery inserts. */
/**
* A retry policy for streaming BigQuery inserts.
*
* <p>This retry policy currently applies only to per-element errors within successful (200 OK)
* BigQuery responses. Non-200 responses (e.g., 400 Bad Request, 500 Internal Server Error) will
* result in a {@code RuntimeException} and bundle failure. The subsequent handling of the failed
* bundle (e.g., retry or final failure) is determined by the specific Runner's fault tolerance
* mechanisms.
*
* @see org.apache.beam.sdk.io.gcp.bigquery.BigQueryServicesImpl.DatasetServiceImpl#insertAll(
* TableReference, java.util.List, java.util.List, BackOff,
* org.apache.beam.sdk.util.FluentBackoff, Sleeper,
* org.apache.beam.sdk.io.gcp.bigquery.InsertRetryPolicy, java.util.List,
* org.apache.beam.sdk.io.gcp.bigquery.ErrorContainer, boolean, boolean, boolean,
* java.util.List)
*/
public abstract class InsertRetryPolicy implements Serializable {
/**
* Contains information about a failed insert.
Expand Down
Loading