Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.50.0] CP #28100 to the release branch. #28110

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

tvalentyn
Copy link
Contributor

Addresses the release-blocking portion of #28084

@tvalentyn
Copy link
Contributor Author

R: @lostluck

@tvalentyn tvalentyn added this to the 2.50.0 Release milestone Aug 22, 2023
@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@tvalentyn tvalentyn requested a review from lostluck August 22, 2023 19:03
@lostluck
Copy link
Contributor

I'll merge after the precommits are done. I suspect the docs pre-commit is just incompatible with release branch merges?

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #28110 (d4694d1) into release-2.50.0 (c42daee) will increase coverage by 1.43%.
Report is 3 commits behind head on release-2.50.0.
The diff coverage is 100.00%.

@@                Coverage Diff                 @@
##           release-2.50.0   #28110      +/-   ##
==================================================
+ Coverage           70.84%   72.28%   +1.43%     
==================================================
  Files                 861      678     -183     
  Lines              105046    99682    -5364     
==================================================
- Hits                74422    72057    -2365     
+ Misses              29062    26063    -2999     
  Partials             1562     1562              
Flag Coverage Δ
python 82.84% <100.00%> (+3.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...hon/apache_beam/runners/worker/bundle_processor.py 94.23% <100.00%> (+0.16%) ⬆️

... and 200 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tvalentyn
Copy link
Contributor Author

doc precommit failure is a known issue: #28104

@lostluck
Copy link
Contributor

Run PythonDocs PreCommit

@lostluck lostluck merged commit 28d20e4 into apache:release-2.50.0 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants