Loosen environment validation checks for RCs #28100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvalentyn
force-pushed
the
env_validation_for_rcs
branch
from
5bb0e4e to
75b453f
Compare
|
R: @damccorm @AnandInguva |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #28100 +/- ##
=======================================
Coverage 72.30% 72.30%
=======================================
Files 678 678
Lines 99771 99777 +6
=======================================
+ Hits 72140 72147 +7
+ Misses 26068 26067 -1
Partials 1563 1563
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
looked at test failures, all are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loosen the environment validation for RC pipelines (see: #28084).
RC releases are currently compatible with RC Docker images, only the SDK version string is different, but SDK installation in the Docker image actually includes the code from the RC .
Some customers make modifications to Beam releases and responsible customers set different version names for such SDKs. It makes sense to still verify that when customers modify the SDK at submission, they also have the matching installation at runtime , as opposed to just check the base version and ignoring all the suffixes.