-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Narrow conditions for PEP 585 error #25084
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25084 +/- ##
==========================================
- Coverage 73.12% 73.12% -0.01%
==========================================
Files 735 735
Lines 98153 98157 +4
==========================================
+ Hits 71776 71778 +2
- Misses 25013 25015 +2
Partials 1364 1364
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, could you add a test that doesn't throw with a non-builtin generic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…5075) Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.107.0 to 0.108.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.107.0...v0.108.0) --- updated-dependencies: - dependency-name: google.golang.org/api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix input type * use sys for size
…che#25080) * Add support for templating in Tour of Beam learning materials * Process learning materials through the template engine * refactoring ci/cd for templated learning materials * adding template processing * refactoring learning content * fixing incorrect sample path * minor formatting comments * missed complexity added add code review comments * fix possible err overwrite Co-authored-by: Timur Sultanov <timur.sultanov@akvelon.com>
* Add support for using builtins typing * lint and formatting * tests * fix tests * fix tests * fix tests * fix tests
Something didn't work syncing to master, just going to close this PR and open a new one |
Makes the conditions for throwing the PEP 585 generics support TypeError more narrow to avoid false positives (e.g. only built-in types can trigger the error now)
Part of work on #23366
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.