GH-45296: [Python] Only enable the string dtype on pandas export for pandas>=2.3 #45383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t for pandas>=2.3
|
|
github-actions
bot
added
Component: Python
awaiting committer review
|
@github-actions crossbow submit -g python |
|
Revision: 5173301 Submitted crossbow builds: ursacomputing/crossbow @ actions-fdd6f9ebad
|
raulcd
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Thanks @jorisvandenbossche
I've validated locally with pandas 2.2
lriggs
pushed a commit
to lriggs/arrow
that referenced
this pull request
Jan 30, 2025
…t for pandas>=2.3 (apache#45383) ### Rationale for this change The option already exists in pandas 2.2, but for that version our code does not work, so restricting it to pandas >= 2.3 * GitHub Issue: apache#45296 Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 4324a06. There were 8 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This was referenced Feb 5, 2025
raulcd
pushed a commit
that referenced
this pull request
Feb 5, 2025
… 2.3 dev version (#45428) ### Rationale for this change Small follow-up on #45383 to ensure this version comparison also does the right thing for the currently not-yet-released dev version of 2.3.0 * GitHub Issue: #45427 Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
amoeba
pushed a commit
to amoeba/arrow
that referenced
this pull request
Feb 11, 2025
…pandas 2.3 dev version (apache#45428) ### Rationale for this change Small follow-up on apache#45383 to ensure this version comparison also does the right thing for the currently not-yet-released dev version of 2.3.0 * GitHub Issue: apache#45427 Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The option already exists in pandas 2.2, but for that version our code does not work, so restricting it to pandas >= 2.3