GH-39277: [Python] Fix missing byte_width attribute on DataType class #39592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
awaiting merge
pitrou
reviewed
Feb 6, 2024
kevinmingtarja
force-pushed
the
GH-39277-missing-byte-width
branch
from
d80c403 to
5da332c
Compare
pitrou
approved these changes
Feb 28, 2024
pitrou
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Thanks for the update @kevinmingtarja . This LGTM, I'll merge if CI passes successfully.
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Feb 28, 2024
… class (apache#39592) ### Rationale for this change As mentioned in the issue, the byte_width attribute was missing on most data types, which is a small annoyance. ### What changes are included in this PR? Add the byte_width attribute on the DataType class (which is the base class of all Arrow data types), instead of on FixedSizeBinaryType (which is a child class of DataType). ### Are these changes tested? Yes, tests were added in `python/pyarrow/tests/test_types.py`. ### Are there any user-facing changes? Yes, users can now access the byte_width attribute on all fixed width data types. * Closes: apache#39277 Authored-by: Kevin Mingtarja <kevin.mingtarja@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 655ae96. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them. |
pitrou
pushed a commit
that referenced
this pull request
Mar 7, 2024
#40381) ### Rationale for this change Fixing the hypothesis tests: - fixup untested changes to the strategies from #40160 - fix a bug in the `byte_width` attribute discovered by hypothesis (introduced by #39592) * GitHub Issue: #40379 Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Mar 8, 2024
… class (apache#39592) ### Rationale for this change As mentioned in the issue, the byte_width attribute was missing on most data types, which is a small annoyance. ### What changes are included in this PR? Add the byte_width attribute on the DataType class (which is the base class of all Arrow data types), instead of on FixedSizeBinaryType (which is a child class of DataType). ### Are these changes tested? Yes, tests were added in `python/pyarrow/tests/test_types.py`. ### Are there any user-facing changes? Yes, users can now access the byte_width attribute on all fixed width data types. * Closes: apache#39277 Authored-by: Kevin Mingtarja <kevin.mingtarja@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Mar 8, 2024
…s tests (apache#40381) ### Rationale for this change Fixing the hypothesis tests: - fixup untested changes to the strategies from apache#40160 - fix a bug in the `byte_width` attribute discovered by hypothesis (introduced by apache#39592) * GitHub Issue: apache#40379 Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
As mentioned in the issue, the byte_width attribute was missing on most data types, which is a small annoyance.
What changes are included in this PR?
Add the byte_width attribute on the DataType class (which is the base class of all Arrow data types), instead of on FixedSizeBinaryType (which is a child class of DataType).
Are these changes tested?
Yes, tests were added in
python/pyarrow/tests/test_types.py.Are there any user-facing changes?
Yes, users can now access the byte_width attribute on all fixed width data types.