ARROW-16717: [C++] Add support for system jemalloc #13373
Conversation
|
@github-actions crossbow submit -g linux -g conan |
|
|
|
Revision: 2fc3e76 Submitted crossbow builds: ursacomputing/crossbow @ actions-38a5518b88
|
|
@github-actions crossbow submit -g linux |
|
Revision: c69a11e Submitted crossbow builds: ursacomputing/crossbow @ actions-1431928845
|
|
|
|
@github-actions crossbow submit -g linux |
|
Revision: e35996d Submitted crossbow builds: ursacomputing/crossbow @ actions-c078080dc9
|
To distinct with system malloc() family.
|
@github-actions crossbow submit -g conan -g linux |
|
Revision: aebd6ac Submitted crossbow builds: ursacomputing/crossbow @ actions-c1a7ee135a
|
|
|
||
| } // namespace memory_pool | ||
|
|
||
| #define RETURN_IF_JEMALLOC_ERROR(ERR) \ |
There was a problem hiding this comment.
Can we #undef it after using it?
| @@ -5,7 +5,7 @@ usr/lib/*/cmake/arrow/ArrowTargets*.cmake | |||
| usr/lib/*/cmake/arrow/Find*Alt.cmake | |||
| usr/lib/*/cmake/arrow/FindArrow.cmake | |||
| usr/lib/*/cmake/arrow/FindBrotli.cmake | |||
| usr/lib/*/cmake/arrow/Find[STuz]*.cmake | |||
| usr/lib/*/cmake/arrow/Find[STjuz]*.cmake | |||
There was a problem hiding this comment.
It's for reusing the same content in all Debian/Ubuntu distributions.
We can't use system Thrift/utf8proc/Zstandard on some distributions. Find{Thrift,utf8proc,zstd}.cmake aren't installed on these distributions. If we specify FindThrift.cmake explicitly instead of Find[STuz]*.cmake on these distributions, .deb generation is failed because the specified file doesn't exist.
But if we specify Find[STuz]*.cmake, .deb generation isn't failed on these distributions. Because FindSnappy.cmake is always installed and Find[STuz]*.cmake always matches one (FindSnappy.cmake) or more files.
Anyway, we only need one Find*.cmake that is always matched to Find[STuz]*.cmake. We already have FindSnappy.cmake for it. We don't need to add Findjemalloc.cmake to it. So I changed to specify Findjemalloc.cmake explicitly.
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
This reverts commit ec8e23c.
|
@github-actions crossbow submit debian-* ubuntu-* |
|
Revision: 7f99b01 Submitted crossbow builds: ursacomputing/crossbow @ actions-5de55f86f6
|
|
Nice addition, thanks @kou ! |
No description provided.