[C++][Parquet] Add missing array include in size_statistics.cc #45545
Milestone
Comments
amoeba
pushed a commit
that referenced
this issue
Feb 19, 2025
### Rationale for this change This fixed a compile error under Windows and MacOS when attempting to package this library as a Conan package: conan-io/conan-center-index#26623 ### What changes are included in this PR? It adds 2 missing headers from the STL, array and vector, which cause resulting compiler errors. ### Are these changes tested? They are tested and passing for the Conan package of these libraries here: conan-io/conan-center-index#26623 ### Are there any user-facing changes? No, only changes within a source file. * GitHub Issue: #45545 Authored-by: Antony Peacock <ant.peacock@gmail.com> Signed-off-by: Bryce Mecum <petridish@gmail.com>
|
Issue resolved by pull request 45554 |
amoeba
pushed a commit
that referenced
this issue
Feb 24, 2025
### Rationale for this change This fixed a compile error under Windows and MacOS when attempting to package this library as a Conan package: conan-io/conan-center-index#26623 ### What changes are included in this PR? It adds 2 missing headers from the STL, array and vector, which cause resulting compiler errors. ### Are these changes tested? They are tested and passing for the Conan package of these libraries here: conan-io/conan-center-index#26623 ### Are there any user-facing changes? No, only changes within a source file. * GitHub Issue: #45545 Authored-by: Antony Peacock <ant.peacock@gmail.com> Signed-off-by: Bryce Mecum <petridish@gmail.com>
kou
pushed a commit
to kou/arrow
that referenced
this issue
Feb 25, 2025
### Rationale for this change This fixed a compile error under Windows and MacOS when attempting to package this library as a Conan package: conan-io/conan-center-index#26623 ### What changes are included in this PR? It adds 2 missing headers from the STL, array and vector, which cause resulting compiler errors. ### Are these changes tested? They are tested and passing for the Conan package of these libraries here: conan-io/conan-center-index#26623 ### Are there any user-facing changes? No, only changes within a source file. * GitHub Issue: apache#45545 Authored-by: Antony Peacock <ant.peacock@gmail.com> Signed-off-by: Bryce Mecum <petridish@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
#45201 introduced a small regression that seems to affect non-unity compilation under MSVC, as caught by conda-forge/arrow-cpp-feedstock#1706. It looks like it might have been missed on CI because we use unity builds (just a theory).
We should update the includes in that file and make sure it builds cleanly under the same MSVC toolset as conda-forge is using.
Component(s)
C++, Parquet
The text was updated successfully, but these errors were encountered: