Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parquet-testing pin, add tests for new invalid data #6984

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 15, 2025

Which issue does this PR close?

Rationale for this change

As described in #6887 (comment) new invalid parquet files have been added to parquet testing so we need to update the tests.

What changes are included in this PR?

  1. Update parquet-testing pin
  2. Add test for newly added file

Are there any user-facing changes?

No, this is just tests

@alamb alamb added the development-process Related to development process of arrow-rs label Jan 15, 2025
@github-actions github-actions bot added the parquet Changes to the parquet crate label Jan 15, 2025
@alamb alamb changed the title Update parquet testing pin, add tests for new invalid data Update parquet-testing pin, add tests for new invalid data Jan 15, 2025
Copy link
Contributor

@etseidl etseidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb
Copy link
Contributor Author

alamb commented Jan 16, 2025

Thank you for the review @etseidl ❤️

@alamb alamb merged commit c5972d0 into apache:main Jan 16, 2025
17 checks passed
totoroyyb pushed a commit to totoroyyb/arrow-rs that referenced this pull request Jan 20, 2025
…6984)

* Update parquet-testing pin

* Add a test for ARROW-GH-45185.parquet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of arrow-rs parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants