Support casting a FixedSizedList<T>[1] to T
#5779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
reviewed
May 17, 2024
| @@ -183,7 +183,8 @@ impl FixedSizeListArray { | |||
| || nulls | |||
| .as_ref() | |||
| .map(|n| n.expand(size as _).contains(&a)) | |||
| .unwrap_or_default(); | |||
| .unwrap_or_default() | |||
| || (nulls.is_none() && a.null_count() == 0); | |||
There was a problem hiding this comment.
The values array could have a NullBuffer but no actual nulls in it (which happens when you safe-cast from a primitive array). This just accounts for that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
This is a followup to #5340
Rationale for this change
This implements the mirror of #5340 -- casting
FixedSizedList<T>[1]toT. Taken together, this allowsFixedSizedList<T>[1]to be used "as though it were aT" for the purpose of casting.What changes are included in this PR?
cast_single_element_fixed_size_list_to_valuesFixedSizeListArray::try_new: allownullsto beNonewhenvalueshas null buffer with null_count of 0.Are there any user-facing changes?