feat(csharp/src/Drivers/BigQuery): choose the first project ID if not specified #2541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 18, 2025 16:28
lidavidm
changed the title
CurtHagenlocher
requested changes
Feb 25, 2025
csharp/test/Apache.Arrow.Adbc.Tests/MultiEnvironmentTestConfiguration.cs
Outdated
Show resolved
Hide resolved
| public List<string> TestEnvironmentNames { get; set; } = new List<string>(); | ||
|
|
||
| /// <summary> | ||
| /// The active test environment. |
There was a problem hiding this comment.
Comment seems to be at odds with both the property definition and the sample file.
What would it mean for the keys of this dictionary to be different than the list of names in TestEnvironmentNames?
| } | ||
|
|
||
| if (environments.Count == 0) | ||
| throw new InvalidOperationException("Could not find a configured Flight SQL environment"); |
There was a problem hiding this comment.
Is this error message more specific than it should be?
CurtHagenlocher
approved these changes
Mar 3, 2025
|
The C# test failure looks unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*detect-project-id*value is passed). This change locates the first project ID in the list of project IDs and uses it if no project ID is specified.