Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clarify non existence or not defined pod model file #47406

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

enchant3dmango
Copy link
Contributor

Update ambiguous logging.

Related discussions:


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@enchant3dmango enchant3dmango force-pushed the main branch 2 times, most recently from 18ec5a4 to 31fd30b Compare March 6, 2025 18:37
@shivshav
Copy link

shivshav commented Mar 6, 2025

@enchant3dmango Continuing the conversation from this discussion, I tried running the main branch from your fork (https://github.com/enchant3dmango/airflow/tree/main) to check things out and ran into what seem like an unrelated issue so am not able to verify things

Ultimately, it's scheduler and webserver spitting out some combinations of these errors

Unable to load the config, contains a configuration error.
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/logging/config.py", line 400, in resolve
    found = getattr(found, frag)
            ^^^^^^^^^^^^^^^^^^^^
AttributeError: partially initialized module 'airflow' has no attribute 'sdk' (most likely due to a circular import)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.11/logging/config.py", line 402, in resolve
    self.importer(used)
ModuleNotFoundError: No module named 'airflow.sdk'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/lib/python3.11/logging/config.py", line 561, in configure
    filters[name] = self.configure_filter(filters[name])
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/logging/config.py", line 698, in configure_filter
    result = self.configure_custom(config)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/logging/config.py", line 479, in configure_custom
    c = self.resolve(c)
        ^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/logging/config.py", line 407, in resolve
    raise v from e
ValueError: Cannot resolve 'airflow.sdk.execution_time.secrets_masker.SecretsMasker': No module named 'airflow.sdk'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/airflow/.local/bin/airflow", line 5, in <module>
    from airflow.__main__ import main
  File "/home/airflow/.local/lib/python3.11/site-packages/airflow/__init__.py", line 78, in <module>
    settings.initialize()
  File "/home/airflow/.local/lib/python3.11/site-packages/airflow/settings.py", line 629, in initialize
    LOGGING_CLASS_PATH = configure_logging()
                         ^^^^^^^^^^^^^^^^^^^
  File "/home/airflow/.local/lib/python3.11/site-packages/airflow/logging_config.py", line 74, in configure_logging
    raise e
  File "/home/airflow/.local/lib/python3.11/site-packages/airflow/logging_config.py", line 69, in configure_logging
    dictConfig(logging_config)
  File "/usr/local/lib/python3.11/logging/config.py", line 823, in dictConfig
    dictConfigClass(config).configure()
  File "/usr/local/lib/python3.11/logging/config.py", line 563, in configure
    raise ValueError('Unable to configure '
ValueError: Unable to configure filter 'mask_secrets'

I should note, this happens on a fresh Docker container with no custom configuration even mounted, and I was able to get the source version of 2.10.4 installed and working the same way, so I'm guessing something in main is off?

In any case, I think the combination of the clearer log message and setting it to log.info would be awesome for my use case. I don't wanna waste anyone else's time trying to debug my setup but am happy to continue trying to test if that's desirable 😄

@enchant3dmango
Copy link
Contributor Author

@shivshav I've changed my mind. In that case, I think we can open another PR. Let's keep it like this for now.

@shivshav
Copy link

shivshav commented Mar 7, 2025

@shivshav I've changed my mind. In that case, I think we can open another PR. Let's keep it like this for now.

@enchant3dmango No worries! Sounds good with me, I appreciate all the help you've given so far so thank you for that 🙏🏾 I can take a look at figuring out the warning ➡️ info change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:cncf-kubernetes Kubernetes provider related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants