Clean up API server config and cli args #47083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedcunningham
added
the
full tests needed
boring-cyborg
bot
added
area:API
jedcunningham
force-pushed
the
break_webserver
branch
from
b19b146 to
3447f05
Compare
jedcunningham
force-pushed
the
break_webserver
branch
from
cac2524 to
fcab914
Compare
This included renaming the following args to better match fastapi/uvicorn: - `--hostname` -> `--host` - `--debug` -> `--dev` The following config options were removed (there isn't an equivalent currently): - `[webserver] error_logfile` - `[webserver] access_logformat` The following config options were moved/renamed to the `api` section. - `[webserver] web_server_host` has been moved to `[api] host` - `[webserver] web_server_port` has been moved to `[api] port` - `[webserver] workers` has been moved to `[api] workers` - `[webserver] web_server_worker_timeout` has been moved to `[api] worker_timeout` - `[webserver] web_server_ssl_cert` has been moved to `[api] ssl_cert` - `[webserver] web_server_ssl_key` has been moved to `[api] ssl_key` - `[webserver] access_logfile` has been moved to `[api] access_logfile`
jedcunningham
force-pushed
the
break_webserver
branch
from
7ae438c to
458b23e
Compare
jedcunningham
changed the title
webserver command and point people at the new api-server
ashb
reviewed
Feb 27, 2025
|
Hmm, it wasn't a conscious choice, I didn't think to do it. In fact, I think there are some others I should go do retroactively too... |
|
Good call. Pushed. |
ashb
approved these changes
Feb 27, 2025
Sharashchandra
pushed a commit
to Sharashchandra/airflow
that referenced
this pull request
Feb 28, 2025
This included renaming the following args to better match fastapi/uvicorn: - `--hostname` -> `--host` - `--debug` -> `--dev` The following config options were removed (there isn't an equivalent currently): - `[webserver] error_logfile` - `[webserver] access_logformat` The following config options were moved/renamed to the `api` section. - `[webserver] web_server_host` has been moved to `[api] host` - `[webserver] web_server_port` has been moved to `[api] port` - `[webserver] workers` has been moved to `[api] workers` - `[webserver] web_server_worker_timeout` has been moved to `[api] worker_timeout` - `[webserver] web_server_ssl_cert` has been moved to `[api] ssl_cert` - `[webserver] web_server_ssl_key` has been moved to `[api] ssl_key` - `[webserver] access_logfile` has been moved to `[api] access_logfile`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This included renaming the following args to better match
fastapi/uvicorn:
--hostname->--host--debug->--devThe following config options were removed (there isn't an equivalent
currently):
[webserver] error_logfile[webserver] access_logformatThe following config options were moved/renamed to the
apisection.[webserver] web_server_hosthas been moved to[api] host[webserver] web_server_porthas been moved to[api] port[webserver] workershas been moved to[api] workers[webserver] web_server_worker_timeouthas been moved to[api] worker_timeout[webserver] web_server_ssl_certhas been moved to[api] ssl_cert[webserver] web_server_ssl_keyhas been moved to[api] ssl_key[webserver] access_logfilehas been moved to[api] access_logfile