Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cross reference for Edge Executor in Airflow docs #43136

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Oct 18, 2024

Follow-up of #42051 . After merging to main, I built docs for edge executor and pushed the inventory file to s3 (to s3://airflow-docs --> the one backing https://s.apache.org/airflow-docs/), so it is Airflow docs and can understand where the cross-ref is coming from since it downloads the inventory file.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Follow-up of apache#42051 . After merging to main, I built docs for edge executor and pushed the inventory file to s3, so it is Airflow docs and can understand where the cross-ref is coming from since it downloads the inventory file.
@kaxil kaxil merged commit 66f9f37 into apache:main Oct 18, 2024
43 checks passed
@kaxil kaxil deleted the add-edge-doc-cross-ref branch October 18, 2024 00:47
@jscheffl
Copy link
Contributor

Aaaah, @kaxil THANKS very much! I was scratching my head why the other PR always failed. I actually did not want to add this cross-reference first-hand but remember that some pre-commit check forced me for consistentcy to add it. Good that you resolved this!

harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
Follow-up of apache#42051 . After merging to main, I built docs for edge executor and pushed the inventory file to s3, so it is Airflow docs and can understand where the cross-ref is coming from since it downloads the inventory file.
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
Follow-up of apache#42051 . After merging to main, I built docs for edge executor and pushed the inventory file to s3, so it is Airflow docs and can understand where the cross-ref is coming from since it downloads the inventory file.
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
Follow-up of apache#42051 . After merging to main, I built docs for edge executor and pushed the inventory file to s3, so it is Airflow docs and can understand where the cross-ref is coming from since it downloads the inventory file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants