Ensure stable secondary ordering #43085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @bugraoz93 |
bugraoz93
approved these changes
Oct 16, 2024
|
@pierrejeambrun This was the method I mentioned as unused. Thanks for including the removal and the fix! |
|
I believe the fix for the failing check has already been merged in here #43087 |
pierrejeambrun
force-pushed
the
enforce-stable-order-secondary-ordering
branch
from
10dd810 to
b6671d0
Compare
kaxil
approved these changes
Oct 17, 2024
R7L208
pushed a commit
to R7L208/airflow
that referenced
this pull request
Oct 17, 2024
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
PaulKobow7536
pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The secondary default ordering is just to be sure that in case of equality on the primary ordering criteria objects follow a stable ordering. This is not the case by default and I added that because I obversed some flakyness on some tests due to that.
Was removed in #42782 by mistake. (secondary ordering is the same as the first one)